Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October 2020 Release #246

Merged
merged 585 commits into from
Oct 15, 2020
Merged

October 2020 Release #246

merged 585 commits into from
Oct 15, 2020

Conversation

s-canchi
Copy link
Contributor

@s-canchi s-canchi commented Oct 13, 2020

PR Checklist

PR Description

This PR will merge all the latest updates from dev to the public facing website and is part of the October 2020 release.

Preview link
https://cfde-training-and-engagement--246.com.readthedocs.build/en/246/

Review format

Hopefully there are no changes, but if there are please create a PR to dev and merge to update the changes.

Timeline

On or before October 15, 2020

marisalim and others added 30 commits September 21, 2020 13:02
…o docs/General-Tutorials/Javascript-dropdown-box/demo_javascript.md
…ered.md to docs/General-Tutorials/Javascript-dropdown-box/demo_javascript_rendered.md
…d to docs/General-Tutorials/Javascript-dropdown-box/javascript_chooser.md
Adding landing pg info for Sphinx and Javascript tutorials
Learning objectives and pre-reqs added to protected branches tutorial and Jekyll tutorial
…le guide (#228)

* Modifying MIME type landing pg to match style guide

* Formatting stylesheets to reduce table cell width

* Editing landing pg to remove div elements

* Updated MkDocs tutorial according to style guide

* Wording fix in MIME landing pg

* Revert back to origin wording in MIME landing pg

* Added tutorial resources and modified prereq

* Added installation text

* Reformatted prereq list

* Updated material install text

* Added pkg manager example in prereq
@s-canchi s-canchi added the Oct-2020 Website release for October 2020 label Oct 13, 2020
@s-canchi s-canchi self-assigned this Oct 13, 2020
@ACharbonneau
Copy link
Contributor

I hadn't really clicked through the whole portal tutorial until today, and it's got way more than I expected! That's awesome :)

I do think we should change this line in the description tho:

Researchers will learn how to apply for protected data access for files included in their manifest.

There is a place where you tell them that dbGaP has instructions, but we don't really teach people how to do it. I think I would just drop that line.

Also, in the left panel, can we change the topics for this tutorial? the longer ones are really good, but I honestly had no idea what was going to happen when I clicked on "Blood Cancer" or "Movement Related Disorders". I think it would be fine to just get rid of those two headers completely and just have the more informative titles that are under them anyway. The extra navigation doesn't seem to be doing anything other than being slightly confusing.

I also think it would be a lot nicer/friendlier if each of the top navigation pages for the website had a line or two of explanation. (Bioinformatics Skills, Cheat sheets, etc). Right now, the landing pages for those are just lists of links. But they should really have just a bit of text first. Something like what Jeremy proposed for 'short explanations of what each tab is' except it should be in the tab, rather than on the front page.

@s-canchi
Copy link
Contributor Author

Those are some good comments. I will drop the line about the restricted data access. With regards to TOC structure I will wait to hear some team consensus since it was suggested by the reviewers of the PR @abhijna and @marisalim to implement the current structure. Will also add in the brief explanation to each tab.

@abhijna
Copy link
Collaborator

abhijna commented Oct 14, 2020

title suggestions:

Use case 1: Gathering and finding datasets related to blood cancer
Use case 2: Gathering and finding datasets related to movement disorders

or just

Use case 1: Gathering datasets related to blood cancer
Use case 2: Gathering datasets related to movement disorders

@josesanchez1815
Copy link
Contributor

josesanchez1815 commented Oct 14, 2020

For the Web Development I think the estimated times to complete tutorials should be tables rather than tabs. Its nice to see all that information in a single format rather than clicking through all the tabs. That's one suggestion I have. It can wait til our next deadline if need be. Or I can make the changes. @s-canchi @abhijna @marisalim @jeremywalter

@s-canchi
Copy link
Contributor Author

s-canchi commented Oct 14, 2020

That's a valid point @josesanchez1815. However, unlike the multipage tutorials, the table format for the the single page will have redundant information for lesson name and description. Table format for only one column also seems excessive. Hence, the tabbed format was chosen to instead include all the associated information. If we change it to the table for tutorials under Web Development tab we would have to change the format for all other single page tutorials. I think we can revisit the format for the next release if need be.

josesanchez1815 and others added 8 commits October 14, 2020 16:09
Updated directions about the geographic location portion line 23.
Updated a typo utilise to utilize.
Geographic location update and typos
… pages of tutorials (#247)

* added brief explanation to index pgs of tutorials

* add exclamation pt

* update tab org description

* re-write of Bioinformatics landing page

* slight re-write for web development tab

* edits to cheat sheets landing pg

* small txt edits

* fixed order of lessons and minor text edits in bioinfo section

* minor text edits to web devlp index

* minor text edits to cfde int index

* txt edit to web devo index

* added ending statemnet in portal index

* minor grammar edits

* made word cloud align left on home pg

* revert back img left align

Co-authored-by: Marisa Lim <marisalim@users.noreply.github.com>
Co-authored-by: Jeremy Walter <40613731+jeremywalter@users.noreply.github.com>
Co-authored-by: marisalim <marisa_lim@pacbell.net>
Copy link
Contributor

@ACharbonneau ACharbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously didn't read all of the everything, but I trust you all did. And I think the overall website feel is delightful

@ctb
Copy link
Contributor

ctb commented Oct 15, 2020 via email

@s-canchi s-canchi merged commit 6b69026 into stable Oct 15, 2020
Copy link
Contributor

@josesanchez1815 josesanchez1815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears Ok to me. I randomly went through content and hyperlinks and most of it seems fine content wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Oct-2020 Website release for October 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants