-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The enlarged result is different from waifu2x-caffe. #4
Comments
In addition, Benchmark score seems to be worse than waifu2x-caffe. waifu2x-caffe RGB waifu2x-caffe CUnet waifu2x-ncnn-vulkan CUnet This is the bat file I used for benchmarking. I use Google Translate because I am not good at English. |
thanks for your report |
|
deconvolution operator produce wrong result on fp16 storage/arithmetic mode. |
the underlying ncnn library get fixed in Tencent/ncnn@9643916 |
20190407 package updated, please try the new binary |
There is no change in the output result using the new binary. |
hi, I just tried the new binary with your original image on AMD r9-m290x machine and my Intel UHD 620 laptop, the output image looks the same with caffe one. waifu2x.exe |
new binary 20190408 has been uploaded with a workaround for gtx20 and vega series. |
Even in my environment, I confirmed that this problem was solved. |
In the case of visual inspection, I do not feel much difference, but there seems to be a little difference in the score of Benchmark. waifu2x-caffe RGB waifu2x-caffe CUnet waifu2x-ncnn-vulkan(20190408) CUnet |
https://i.imgur.com/SFs1Ws8.gif If you look closely and compare it, the contrast of the image seems different. よく見比べてみると画像のコントラストが異なるようです。 |
yeah, I found the little difference too. |
20190414 package updated, please try the new binary |
Yes, ver 20190414 is almost the same as waif2x-caffe. はい、ver 20190414ではwaif2x-caffeと殆ど変わらなくなりました。 Ryzen 2400G waifu2x-caffe ver 1.2.0.2 waifu2x-ncnn-vulkan ver 20190407 and 20190408 waifu2x-ncnn-vulkan ver 20190414
|
Ryzen 2400G
[0 AMD Radeon(TM) RX Vega 11 Graphics] queueC=1 queueT=2 memU=2 memDL=0 memHV=1
[0 AMD Radeon(TM) RX Vega 11 Graphics] fp16s=1 fp16a=1 int8s=1 int8a=1
input file
waifu2x-ncnn-vulkan ver 20190407
waifu2x-caffe ver 1.2.0.2
The text was updated successfully, but these errors were encountered: