Develop #137

kaaholst · 2015-08-02T09:08:07Z

Implement "Play from here"

(cherry picked from commit 4117be1)

NOTE Only English and Danish language, other translations are missing.

TODO This is dependant on the albumtrack sort order for the songs query, which is available from server version 7.6 NOTE Only English, German, Dutch and Danish language, other translations are missing. Signed-off-by: Kurt Aaholst <kaaholst@gmail.com>

Play from here for artists, genres and years, requires title sort order "albumtrack", which is available from server version 7.6. Sort order "albumtrack" and hence play from here are disabled for earlier server versions.

When showing all titles of a item which can be played, insert the name of the item in the play and queue menu options. Signed-off-by: Kurt Aaholst <kaaholst@gmail.com>

DOWNLOAD_ITEM -> DOWNLOAD PLAYLIST_REMOVE_ITEM -> PLAYLIST_REMOVE So now the ITEM part indicates that the string takes a item name argument.

We receive alarm playlist in AlarmActivity on a background thread. This updates mAlarmPlaylists which is passed to and used in AlarmView.setAlarmPlaylists on the UI thread. This causes for a possible concurrency problem, so now mAlarmView is both updated and passed to setAlarmPlaylists on the UI thread. This fixes: https://fabric.io/squeezer/android/apps/uk.org.ngo.squeezer/issues/55c6c8e5e0d514e5d6daa019

notification preference Signed-off-by: Kurt Aaholst <kaaholst@gmail.com>

If a configurable action for song or album is not set. or is NONE, a popup with the possible actions, and "Just once" and "Always" options, similar to the standard Android way of resolving intents. This requires Dialog.setOnShowListener so it is for API level 8 (froyo) or later. API level 7 still have to select the default action via settings.

and move them to uk.org.squeezer.framework

and move it to uk.org.squeezer.framework

in PlayableItemAction.Type and ThemeManager.Theme

The song and album search results are displayed in a list or a grid as selected in the song album lists respectively.

This version fixes a NoClassDefFoundError, thus eliminates the need to reference a special fork of EventBus, and thereby also removes an Android Studio problem, as it seems the EventBus project does not work with Android Studio/Intellij.

move the test from src/androidTest folder to src/test.

nikclayton · 2016-04-24T15:09:49Z

Squeezer/src/main/java/uk/org/ngo/squeezer/itemlist/AlarmsActivity.java

-                    @Override
-                    public void run() {
+                    mAlarmPlaylists.addAll(items);
+                    if (start + items.size() >= count) {
                        mAlarmView.setAlarmPlaylists(mAlarmPlaylists);


I'll merge as is for the moment, but what if just this line was changed to be:

mAlarmView.setAlarmPlaylists(ImmutableList.copyOf(mAlarmPlaylists);

instead?

That seems like a good idea.

Note that the semantics is slightly different, as the UI is not updated until we have received all the items, which also is how it worked originally.

One drawback is that copy of the list is thrown away when AlarmView is done with it, even more so as all AlarmView does with it, is add a few category items to it.

Actually the semantics are the same the UI isn't updated until all items are received.

nikclayton · 2016-05-15T18:42:41Z

Squeezer/build.gradle

@@ -39,7 +39,7 @@ dependencies {
    compile 'com.google.code.findbugs:jsr305:2.0.2'

    // EventBus, https://github.com/greenrobot/EventBus.
-    compile project(':libs:eventbus:EventBus')
+    compile 'de.greenrobot:eventbus:2.4.1'


I don't know that 2.4.1 actually fixes this.

Ahead of releasing 1.4.1 I've been launching Squeezer on some emulators running API 7, and they crash with

05-15 18:27:25.134 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.144 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.154 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.154 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.154 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.165 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.165 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.165 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.165 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.185 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.185 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.185 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.185 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.185 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.195 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.195 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.195 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.195 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.205 3064-3064/uk.org.ngo.squeezer W/System.err: 05-15 18:27:25.205 3064-3064/uk.org.ngo.squeezer W/System.err: java.lang.NoSuchMethodException
at java.lang.Class.getDeclaredMethods(Native Method)
at java.lang.ClassCache.getDeclaredMethods(ClassCache.java:153)
at java.lang.Class.getDeclaredMethods(Class.java:792)
at a.b.a.o.a(SubscriberMethodFinder.java:76)
at a.b.a.c.register(EventBus.java:164)
at a.b.a.c.register(EventBus.java:144)
at uk.org.ngo.squeezer.service.SqueezeService$EventBus.register(SqueezeService.java:1691)
at uk.org.ngo.squeezer.service.SqueezeService.onCreate(SqueezeService.java:220)
at android.app.ActivityThread.handleCreateService(ActivityThread.java:2780)
at android.app.ActivityThread.access$3200(ActivityThread.java:119)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1917)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:123)
at android.app.ActivityThread.main(ActivityThread.java:4363)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:521)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
at dalvik.system.NativeStart.main(Native Method)

Just did a few more tests based on the faq mentioned in issue 149 .

The exception is thrown if the class has methods with a parameter that is unavailable to the API level of the device.

When I launch squeezer on an API 7 (Android 2.1) emulator I get a crash on line 81 of SubscriberMethodFinder.java, which makes sense as this is the fallback ("plan b") applied by EventBus when getDeclaredMethods fails.

I then comment out the Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP section of updateOngoingNotification and the crash disappears.

I suspect (but I'm guessing here as I haven't done the test) that the crash would happen also with the EventBus fork pulled in and on EventBus 3.0 (unless we use an index).

kaaholst · 2016-05-15T21:12:34Z

I think it should fix it.

EventBus issue 149 references a commit, which implement the recommended workaround by @yuzeh, who's fork we previously referenced in Squeezer.

I haven't been able to trigger the problem though, so I don't know if 2.4.1 actually fixes it.

I don't understand the supplied stacktrace though. When I open SubscriberMethodFinder.java from eventbus-2.4.1-sources.jar, line 76 is: Method[] methods = clazz.getDeclaredMethods();, and this line is protected by a try-catch (Throwable) and falls back to getMethods(). So how can it throw a NoSuchMethodException?

nikclayton · 2016-06-04T23:21:58Z

I've got a nagging feeling this was caused by the Instant Run feature in newer versions of Android Studio (where it hot-patches new code in to the app instead of deploying a fresh APK). I turned that off, and can't reproduce.

1.4.1-beta contains 2.4.1 now (no crashes in Crashlytics that I can see), and the eventbus3 branch has 15e08b0 which is all the work (I think) necessary to use eventbus v3. I'll merge that in after 1.4.1 is released.

nikclayton and others added 22 commits May 25, 2015 19:38

Update references to code.google.com to point to the GitHub pages site.

90b9473

(cherry picked from commit 4117be1)

Merge branch 'release-1.3.1'

c84405b

Merge branch 'release-1.4.0'

ff5c61d

Implement "Play from here" in albums and playlists

72511b9

NOTE Only English and Danish language, other translations are missing.

Play from here only for supported server versions

49903de

Play from here for artists, genres and years, requires title sort order "albumtrack", which is available from server version 7.6. Sort order "albumtrack" and hence play from here are disabled for earlier server versions.

Show name if playlist item

7e1443b

When showing all titles of a item which can be played, insert the name of the item in the play and queue menu options. Signed-off-by: Kurt Aaholst <kaaholst@gmail.com>

For consistency remove ITEM from string id's

b6fc3c7

DOWNLOAD_ITEM -> DOWNLOAD PLAYLIST_REMOVE_ITEM -> PLAYLIST_REMOVE So now the ITEM part indicates that the string takes a item name argument.

Fix FloatLabelLayout for internet radio search

fb65ed7

Merge branch 'master' into develop

d9cec4d

Merge branch 'master' into develop

363e7d9

Temp fix for index out of bounds for

409a776

notification preference Signed-off-by: Kurt Aaholst <kaaholst@gmail.com>

Move enum helper interfaces to upper level

502ad4c

and move them to uk.org.squeezer.framework

Move EnumIdLookup upper level

789555c

and move it to uk.org.squeezer.framework

Use EnumWithText

e57e9f3

in PlayableItemAction.Type and ThemeManager.Theme

Export NowPlaying and CurrentPlaylist activities

abbaa88

Search activity follows grid selection

1dc8864

The song and album search results are displayed in a list or a grid as selected in the song album lists respectively.

Proper title in ask for action dialog

b194656

Upgrade to EventBus 2.4.1

0e907e8

This version fixes a NoClassDefFoundError, thus eliminates the need to reference a special fork of EventBus, and thereby also removes an Android Studio problem, as it seems the EventBus project does not work with Android Studio/Intellij.

Add reflection tests as JVM test

b8aac23

move the test from src/androidTest folder to src/test.

nikclayton reviewed Apr 24, 2016
View reviewed changes

nikclayton merged commit b8aac23 into nikclayton:develop Apr 26, 2016

nikclayton mentioned this pull request Apr 26, 2016

Fix FloatLabelLayout for internet radio search #139

Closed

nikclayton reviewed May 15, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop #137

Develop #137

kaaholst commented Aug 2, 2015

nikclayton Apr 24, 2016

kaaholst Apr 24, 2016

kaaholst Apr 24, 2016

nikclayton May 15, 2016

kaaholst May 17, 2016

kaaholst commented May 15, 2016

nikclayton commented Jun 4, 2016

Develop #137

Develop #137

Conversation

kaaholst commented Aug 2, 2015

nikclayton Apr 24, 2016

Choose a reason for hiding this comment

kaaholst Apr 24, 2016

Choose a reason for hiding this comment

kaaholst Apr 24, 2016

Choose a reason for hiding this comment

nikclayton May 15, 2016

Choose a reason for hiding this comment

kaaholst May 17, 2016

Choose a reason for hiding this comment

kaaholst commented May 15, 2016

nikclayton commented Jun 4, 2016