focusStyle, hoverStyle, activeStyle and so on should extend not overwrite style

[nikgraf]

Same for disabledHover. It should extend disabledStyle.

I noticed I made this mistake at the Select. There might be other places. We should double-check.

• fix hoverStyle behaviour in Select
• fix focusStyle behaviour in Select
• deprecate duplicated styles definitions in style.select.hoverStyle, style.select.activeStyle, style.select.focusStyle
• investigate if other components have the same issue
• update documentation to explain how psuedoClass styles work in Belle

[nikgraf]

We probably should also make that clear in the documentation as well (every component).

Could be done with an example like:

// When hovering the component, the color will be blue and the background still green.
<Button style={{ color: red, background: green }} hoverStyle={{ color: blue }}>Follow</Button>

[jpuri]

Our implementation of Rating does not have a hoverStyle or disabledHoverStyle....hover for Rating is implemented at level of character and not wrapper, thus we have this: hoverCharacterStyle.

Its look fine in terms of logic, but api looks different from other components.

[jpuri]

Why should disabledHoverStyle extend disabledStyle ?
Former is applied as pseudo class.

[nikgraf]

@jpuri by extend I meant it like this:

// When hovering the diabled component, the color will be blue and the background still green.
<Button disabledStyle={{ color: red, background: green }} disabledHoverStyle ={{ color: blue }}>Follow</Button>

Regarding the API: Would you suggest to change the API for Rating? While it doesn't comply with the other components styling configuration I though it would make more sense as the style is directly applied to the character. Maybe the old html structure was better?

[jpuri]

No this structure is good....its just about how we have grouped and designed the styles.
We can change our styling api for Rating to comply with other components and still keep same structure...

I see the list of stuff to be completed for release just growing as we are working on things... :)

[nikgraf]

👍 sure, I added this issue: #86

[nikgraf]

Solved with this PR: #87