Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typehints #77

Closed
SamMousa opened this issue Mar 19, 2019 · 1 comment
Closed

Add typehints #77

SamMousa opened this issue Mar 19, 2019 · 1 comment

Comments

@SamMousa
Copy link
Contributor

SamMousa commented Mar 19, 2019 •
edited
Loading

Since PHP7.1, which is required in composer.json the iterable type hint is supported.

Would you:

  1. Accept a PR that makes the parameters to functions that take iterables typed.

Or, if not 1:

  1. Accept a PR that adds iterable as an option in the PHPDoc (since array|Traversable does not include iterable).

?
@jvasseur
Copy link
Contributor

The master branch (which is the one that requires PHP 7.1) already has iterable type hints where possible (it was done in #52), it's just not released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SamMousa @jvasseur