1.1.1: Add GitHub Actions for publishing Windows dlls on a release #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start creating releases again, to have something to attach the artifacts for Windows to
TysonAndre
force-pushed
the
build-dlls
branch
from
298fabe
to
6640877
Compare
Avoid ambiguity and put `php-` and `ast-` before the corresponding version (e.g. avoid calling it Windows-8.1 for php 8.1). These will be on a release page with artifacts for other platforms
nikic
reviewed
Oct 18, 2022
| uses: actions/upload-artifact@v3.1.0 | ||
| with: | ||
| name: ast-${{github.ref_name}}-Windows-php-${{matrix.version}}-${{matrix.arch}}-${{matrix.ts}} | ||
| path: .install |
There was a problem hiding this comment.
Can this be integrated into the normal workflow, like in apcu?
There was a problem hiding this comment.
It can be - largely, I don't want dlls available for non-release versions in case we change our minds about how a feature is implemented before a release - it's a difference of what triggers the build
on:
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
release:
types: [published]
on: [push, pull_request]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the release checklist to start creating releases again.
https://pecl.php.net/package/ast still doesn't have releases, and the php 8.2.0 stable release is close to being published
A similar workflow succeeded in https://github.com/TysonAndre/var_representation/actions/runs/3260935531
This limits dlls to be published on stable releases, to save resources, and to avoid creating dlls for unmerged PRs or functionality that may be revised later.