Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pregenerated Ragel output be committed to the repo? #10

Closed
niklata opened this issue Oct 20, 2020 · 1 comment
Closed

Should pregenerated Ragel output be committed to the repo? #10

niklata opened this issue Oct 20, 2020 · 1 comment
Assignees
Labels

Comments

@niklata
Copy link
Owner

niklata commented Oct 20, 2020

I don't know how much of an inconvenience it is to require Ragel to be installed when building ndhc. If it's enough of a problem that it deters people from trying out or using ndhc, then a simple solution is to bundle pregenerated Ragel output files into the repository. This approach is already seen with many other projects for quite some time, such as fftw and its ocaml-generated output that most users are never aware of.

This of course will require a bit of effort to make sure that on my local machines the files are always rebuilt as I test, but that's easily done.

Would this be helpful?

@niklata niklata self-assigned this Oct 20, 2020
@niklata
Copy link
Owner Author

niklata commented Jan 23, 2022

I've done this in the process of converting to solely using GNU Make as the build system.

@niklata niklata closed this as completed Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant