-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): Add Instagram service #43
Conversation
Hey @alankan886, thanks for your contribution and thanks for alerting me to the fact that ahmdrz/goinsta currently seems pretty inactive. I will try to contact the developer. If I can't reach him, I really only see three solutions:
I would like to know your opinion on this @j-wil @KrishanBhalla. Until we make a decision, I'm leaving the PR open. Really, I appreciate your contribution and would love to merge it right now but we need to decide this first; sorry! |
@nikoksr, thanks for letting me know, that's unfortunate. I think with option 1, we will still be relying on |
@alankan886 I have already contacted the developer and am now waiting for his response. Just gave this a quick Google search and found this. |
@nikoksr ah good find, so perhaps just wait until Facebook publishes the updated API. |
@alankan886 yes, then possibly our best choice. We are now waiting for the answer from the developer and then decide. Again, I'm really sorry for the inconvenience. I was very busy the days, otherwise I would have answered earlier that we must first contact the developer. |
@nikoksr I think you're on the right track here we have to imagine notify running in production environments where people may rely on the notifications produced by our work here. +1 waiting for messenger insta integration |
Closing this for now. Will update the Facebook-Messenger issue (#4). |
Add support for Instagram service.
I would be happy to add unit tests, but I skimmed through #1 and it seems like the decision on testing is still pending.