Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend handle to accept any selectors instead of ID? #2

Closed
yfwz100 opened this issue Oct 12, 2018 · 1 comment
Closed

Extend handle to accept any selectors instead of ID? #2

yfwz100 opened this issue Oct 12, 2018 · 1 comment

Comments

@yfwz100
Copy link

yfwz100 commented Oct 12, 2018

Suggest replacing the following code

v-drag/src/index.js

Line 244 in cc6a1d6

const valueElement = document.getElementById(handle);

into

const valueElement = el.querySelector(handle);
@yfwz100 yfwz100 changed the title Extend handle to accept any selectors instead of just ID? Extend handle to accept any selectors instead of ID? Oct 12, 2018
@nil
Copy link
Owner

nil commented Dec 25, 2018

This feature has been added on v2.1.0.

@nil nil closed this as completed Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yfwz100 @nil