[MRG] Fix cache mixin tests

[jeromedockes]

test_cache_shelving was not passing when run on its own (because it depended on func_code.py being in the joblib directory whereas this may not be the case if the function is already in joblib's in-memory hash store)

and several tests were not cleaning up their temporary directories

[codecov]

Codecov Report

Merging #2161 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2161      +/-   ##
==========================================
+ Coverage   92.31%   92.32%   +<.01%     
==========================================
  Files         149      149              
  Lines       18786    18777       -9     
  Branches     2291     2290       -1     
==========================================
- Hits        17342    17335       -7     
  Misses        922      922              
+ Partials      522      520       -2

Impacted Files	Coverage Δ
nilearn/tests/test_cache_mixin.py	95.65% <100%> (+1.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d566678...b371d90. Read the comment docs.

[jeromedockes]

appveyor failure is fetch development dataset failed download and unrelated

[kchawla-pi]

I think due to the permission & membership changes Gael made for Nilearn, I cannot trigger the Appveyor built on the old permissions. You'll have to push a (empty) commit to trigger it.

[GaelVaroquaux]

I think due to the permission & membership changes Gael made for Nilearn, I cannot trigger the Appveyor built on the old permissions.

Darn. Do you have any idea what the problem might be? You should be admin, and hence be able to fix this. At some point, it might be beneficial to move to Azure pipeline, rather than Appveyor, it's more reliable. It's a bit of work, though.

[kchawla-pi]

It's fine, the next commit reset the permissions and it's better than before for all of us. I will implement Azure pipelines again after the alpha release.

…

On Wed, Oct 16, 2019, 15:55 Gael Varoquaux ***@***.***> wrote: > I think due to the permission & membership changes Gael made for Nilearn, I cannot trigger the Appveyor built on the old permissions. Darn. Do you have any idea what the problem might be? You should be admin, and hence be able to fix this. At some point, it might be beneficial to move to Azure pipeline, rather than Appveyor, it's more reliable. It's a bit of work, though. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2161?email_source=notifications&email_token=AB6SXRHDMY3FK6CNBVAMQW3QO4MM3A5CNFSM4I644GM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMSJLY#issuecomment-542713007>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6SXRGQ6FB3DQDX23UBC6LQO4MM3ANCNFSM4I644GMQ> .

[kchawla-pi]

@jeromedockes the old login forappveyor won't work. Since you have write access to nilearn, loggin in with your github account will allow you to restart builds on Appveyor.

@GaelVaroquaux Azure Pipelines itself is ready but many of Nilearn's tests failed on it (though they pass on Appveyor) during the sprint and my local windows machine. Since I dont usually bring a windows machine to work this kept getting deferred. Soon as I release Nilearn & Nistats, I'll prioritize AZP.

[GaelVaroquaux]

Soon as I release Nilearn & Nistats, I'll prioritize AZP.

Cool. It's not a high priority thing. Mostly a core maintenance issue.