New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] update changelog and git blame ignore #3755
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3755 +/- ##
==========================================
+ Coverage 91.54% 91.60% +0.06%
==========================================
Files 139 139
Lines 16591 16591
Branches 3244 3244
==========================================
+ Hits 15188 15198 +10
+ Misses 1402 1390 -12
- Partials 1 3 +2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Related to #3701 (comment) git blame --ignore-revs-file .git-blame-ignore-revs nilearn/image/resampling.py Still shows content from 3651 event though it is supposed to be ignored:
More annoyingly it is also still the case for: git blame --ignore-rev 44933309 nilearn/image/resampling.py |
Behavior is the same on the github interface that supposedly picks up on git blame ignore: https://github.com/Remi-Gau/nilearn/blame/ignore_blame/nilearn/image/resampling.py |
things I have tried:
|
I still cannot make the git blame ignore work properly to ignore the PRs listed in it but at least the PRs for flake8 and isort compliance are listed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup that was my idea. Merging this then. |
* update git-blame-ignore * update changelog * fix * update ignore * fix regex escape * flake8 * use list and not set * simplify rev file * rm spaces * pragmatism wins * rm import * reset plotting files
* add workflow for flynt * configure and run flynt * flake8 * Update .github/workflows/f_strings.yml Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com> * Update nilearn/_utils/data_gen.py Co-authored-by: bthirion <bertrand.thirion@inria.fr> * pre-commit hooks auto-update (#3764) Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com> * [DOC] update changelog and git blame ignore (#3755) * update git-blame-ignore * update changelog * fix * update ignore * fix regex escape * flake8 * use list and not set * simplify rev file * rm spaces * pragmatism wins * rm import * reset plotting files * [FIX] Change error string to match scikit-learn `InvalidParameterError` message (#3763) * Modify ValueError string * Warning based on sklearn version * relax regex for warning on sanitize reorder error (#3766) --------- Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com> Co-authored-by: bthirion <bertrand.thirion@inria.fr> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com>
Closes #3752
Relates to #3653
Changes proposed in this pull request: