[FIX] Change error string to match scikit-learn InvalidParameterError message
#3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3763 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 139 139
Lines 16591 16591
Branches 3244 3244
=======================================
Hits 15188 15188
Misses 1402 1402
Partials 1 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Remi-Gau
approved these changes
Jun 19, 2023
|
Merging this |
Remi-Gau
pushed a commit
to Remi-Gau/nilearn
that referenced
this pull request
Jun 19, 2023
…r` message (nilearn#3763) * Modify ValueError string * Warning based on sklearn version
Remi-Gau
added a commit
that referenced
this pull request
Jun 20, 2023
* add workflow for flynt * configure and run flynt * flake8 * Update .github/workflows/f_strings.yml Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com> * Update nilearn/_utils/data_gen.py Co-authored-by: bthirion <bertrand.thirion@inria.fr> * pre-commit hooks auto-update (#3764) Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com> * [DOC] update changelog and git blame ignore (#3755) * update git-blame-ignore * update changelog * fix * update ignore * fix regex escape * flake8 * use list and not set * simplify rev file * rm spaces * pragmatism wins * rm import * reset plotting files * [FIX] Change error string to match scikit-learn `InvalidParameterError` message (#3763) * Modify ValueError string * Warning based on sklearn version * relax regex for warning on sanitize reorder error (#3766) --------- Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com> Co-authored-by: bthirion <bertrand.thirion@inria.fr> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com>
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 30, 2023
https://build.opensuse.org/request/show/1103307 by user dgarcia + dimstar_suse - Add numpy-1.25.patch, upstream patch gh#nilearn/nilearn#3746 - Add warning-based-sklearn-version.patch, upstream patch gh#nilearn/nilearn#3763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See prerelease dependencies CI error: https://github.com/nilearn/nilearn/actions/runs/5290261152/jobs/9574189485?pr=3762