Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Implement deprecation warnings-as-errors in prerelease test using pytest fixture #3936

Merged
merged 9 commits into from Oct 5, 2023
Merged

[MAINT] Implement deprecation warnings-as-errors in prerelease test using pytest fixture #3936

merged 9 commits into from Oct 5, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Aug 30, 2023

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited

Codecov Report

Merging #3936 (dbb0782) into main (f7d83a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3936   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         145      145           
  Lines       16230    16230           
  Branches     3367     3367           
=======================================
  Hits        14888    14888           
  Misses        797      797           
  Partials      545      545
Flag Coverage Δ
macos-latest_3.10 91.65% <ø> (ø)
macos-latest_3.11 91.65% <ø> (ø)
macos-latest_3.12 91.65% <ø> (ø)
macos-latest_3.8 91.61% <ø> (ø)
macos-latest_3.9 91.61% <ø> (ø)
ubuntu-latest_3.10 91.65% <ø> (ø)
ubuntu-latest_3.11 91.65% <ø> (ø)
ubuntu-latest_3.12 91.65% <ø> (ø)
ubuntu-latest_3.8 91.61% <ø> (ø)
ubuntu-latest_3.9 91.61% <ø> (ø)
windows-latest_3.10 91.59% <ø> (?)
windows-latest_3.11 91.59% <ø> (ø)
windows-latest_3.12 91.59% <ø> (ø)
windows-latest_3.8 91.55% <ø> (ø)
windows-latest_3.9 91.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@ymzayek ymzayek mentioned this pull request Sep 20, 2023
Merged
@ymzayek
Copy link
Member Author

ymzayek commented Sep 20, 2023 •
edited

TODO: set this up as a separate workflow that runs once a month or so like detect_test_pollution workflow. Definitely don't want to burden contributors with failures from a maintenance job.

bthirion
bthirion reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

.github/workflows/check_deprecations.yml Outdated Show resolved Hide resolved
@ymzayek ymzayek force-pushed the maint/depr-warning-as-error branch from 76478cb to dbb0782 Compare October 5, 2023 09:37
@ymzayek ymzayek marked this pull request as ready for review October 5, 2023 09:38
@ymzayek ymzayek requested a review from Remi-Gau October 5, 2023 11:50
Remi-Gau
Remi-Gau approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me.
I guess we should trigger it after merging to get a baseline

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Oct 5, 2023

Good with me. I guess we should trigger it after merging to get a baseline

or do you want to trigger it once before merging?

@ymzayek
Copy link
Member Author

ymzayek commented Oct 5, 2023

Let's merge it and then trigger it manually.

@ymzayek ymzayek merged commit 7739f95 into nilearn:main Oct 5, 2023
32 checks passed
@ymzayek ymzayek deleted the maint/depr-warning-as-error branch October 5, 2023 16:54
@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Oct 5, 2023

Let's merge it and then trigger it manually.

and everything went fine

michellewang pushed a commit to michellewang/nilearn that referenced this pull request Oct 9, 2023
@ymzayek @michellewang
[MAINT] Implement deprecation warnings-as-errors in prerelease test u…
1b44afc 
…sing pytest fixture (nilearn#3936)

* Add fixture

* Add dependencies

* TODO

* Add monthly workflow config

* Numpy deprecation

* Update workflow

* Update

* Add to readme
@ymzayek ymzayek mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthirion bthirion bthirion left review comments

@Remi-Gau Remi-Gau Remi-Gau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion to use warnings-as-errors with pytest in prerelease CI
3 participants
@ymzayek @Remi-Gau @bthirion