Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Deal with Numpy alltrue deprecation #3996

Merged
merged 1 commit into from Sep 20, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Sep 20, 2023

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #3996 (47c42c0) into main (70da7b7) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   91.70%   91.77%   +0.06%     
==========================================
  Files         134      134              
  Lines       15786    15786              
  Branches     3291     3291              
==========================================
+ Hits        14476    14487      +11     
+ Misses        767      755      -12     
- Partials      543      544       +1     
Flag Coverage Δ
macos-latest_3.10 91.68% <100.00%> (ø)
macos-latest_3.11 91.68% <100.00%> (ø)
macos-latest_3.8 91.64% <100.00%> (ø)
macos-latest_3.9 91.65% <100.00%> (ø)
ubuntu-latest_3.10 91.68% <100.00%> (ø)
ubuntu-latest_3.11 91.68% <100.00%> (ø)
ubuntu-latest_3.8 91.64% <100.00%> (?)
ubuntu-latest_3.9 91.65% <100.00%> (?)
windows-latest_3.10 91.63% <100.00%> (ø)
windows-latest_3.11 91.63% <100.00%> (ø)
windows-latest_3.8 91.59% <100.00%> (ø)
windows-latest_3.9 91.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nilearn/plotting/find_cuts.py 88.83% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. LGTM too.

@Remi-Gau Remi-Gau merged commit 3057249 into nilearn:main Sep 20, 2023
28 checks passed
@ymzayek ymzayek deleted the numpy-deprecation branch December 15, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants