Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Finish adding badges to changelog #3968

Merged
merged 4 commits into from Sep 14, 2023
Merged

Conversation

Remi-Gau
Copy link
Collaborator

Changes proposed in this pull request:

  • add badges to all badgeless entries in the changelog

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #3968 (d6325c0) into main (38fb768) will increase coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3968      +/-   ##
==========================================
+ Coverage   91.78%   91.79%   +0.01%     
==========================================
  Files         134      134              
  Lines       15772    15776       +4     
  Branches     3284     3286       +2     
==========================================
+ Hits        14476    14482       +6     
+ Misses        752      751       -1     
+ Partials      544      543       -1     
Flag Coverage Δ
macos-latest_3.10 91.70% <ø> (+<0.01%) ⬆️
macos-latest_3.11 91.70% <ø> (+<0.01%) ⬆️
macos-latest_3.8 91.67% <ø> (+<0.01%) ⬆️
macos-latest_3.9 91.67% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.10 91.70% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.11 91.70% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.8 91.67% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.9 91.67% <ø> (+<0.01%) ⬆️
windows-latest_3.10 91.65% <ø> (+<0.01%) ⬆️
windows-latest_3.11 91.65% <ø> (+<0.01%) ⬆️
windows-latest_3.8 91.61% <ø> (+<0.01%) ⬆️
windows-latest_3.9 91.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@ymzayek
Copy link
Member

ymzayek commented Sep 13, 2023

A few missed ones:

doc/changes/0.2.2.rst:17:- Fetcher for Megatrawl Netmats dataset.
doc/changes/0.3.0.rst:36:- :term:`ANOVA` :term:`SVM` example on Haxby datasets ``plot_haxby_anova_svm`` in Decoding section now uses ``SelectPercentile`` to select :term:`voxels<voxel>` rather than ``SelectKBest``.
doc/changes/0.3.1.rst:16:- **Dropped support for scikit-learn older than 0.14.1** Minimum supported version is now ``0.15``.
doc/changes/0.4.0.rst:29:- Function :func:`~datasets.fetch_atlas_talairach` to fetch the `Talairach atlas <http://talairach.org>`_ (:gh:`1523` by `Jerome Dockes`_).
doc/changes/0.5.0.rst:239:- New :ref:`interactive plotting functions <interactive-plotting>`, eg for use in a notebook.
doc/changes/0.9.2.rst:67:- 64-bit integers in Nifti files: some tools such as FSL, SPM and AFNI cannot

@Remi-Gau
Copy link
Collaborator Author

A few missed ones:

doc/changes/0.2.2.rst:17:- Fetcher for Megatrawl Netmats dataset.
doc/changes/0.3.0.rst:36:- :term:`ANOVA` :term:`SVM` example on Haxby datasets ``plot_haxby_anova_svm`` in Decoding section now uses ``SelectPercentile`` to select :term:`voxels<voxel>` rather than ``SelectKBest``.
doc/changes/0.3.1.rst:16:- **Dropped support for scikit-learn older than 0.14.1** Minimum supported version is now ``0.15``.
doc/changes/0.4.0.rst:29:- Function :func:`~datasets.fetch_atlas_talairach` to fetch the `Talairach atlas <http://talairach.org>`_ (:gh:`1523` by `Jerome Dockes`_).
doc/changes/0.5.0.rst:239:- New :ref:`interactive plotting functions <interactive-plotting>`, eg for use in a notebook.
doc/changes/0.9.2.rst:67:- 64-bit integers in Nifti files: some tools such as FSL, SPM and AFNI cannot

good catch: will fix

doc/changes/0.2.2.rst Outdated Show resolved Hide resolved
doc/changes/0.4.0.rst Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau merged commit d4a6dfb into nilearn:main Sep 14, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the badges branch September 19, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply changelog badges backwards
3 participants