Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] update DOI and add RRID #4032

Merged
merged 3 commits into from Oct 30, 2023
Merged

[MAINT] update DOI and add RRID #4032

merged 3 commits into from Oct 30, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 7, 2023

Changes proposed in this pull request:

  • add new DOI to citation.cff
  • add DOI in readme
  • update how to cite section
  • mention RRID

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4032 (a4ed018) into main (5d32855) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4032   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         143      143           
  Lines       16079    16079           
  Branches     3340     3340           
=======================================
  Hits        14728    14728           
  Misses        804      804           
  Partials      547      547           
Flag Coverage Δ
macos-latest_3.10 91.51% <ø> (ø)
macos-latest_3.11 91.51% <ø> (ø)
macos-latest_3.12 91.51% <ø> (ø)
macos-latest_3.9 91.47% <ø> (ø)
ubuntu-latest_3.10 91.51% <ø> (ø)
ubuntu-latest_3.11 91.51% <ø> (ø)
ubuntu-latest_3.12 91.51% <ø> (ø)
ubuntu-latest_3.9 91.47% <ø> (ø)
windows-latest_3.10 91.46% <ø> (ø)
windows-latest_3.11 91.46% <ø> (ø)
windows-latest_3.12 91.46% <ø> (ø)
windows-latest_3.9 91.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ymzayek
Copy link
Member

ymzayek commented Oct 9, 2023

This sections might also need to be updated depenging on what we decide: https://nilearn.github.io/stable/authors.html#citing-nilearn

@Remi-Gau Remi-Gau marked this pull request as ready for review October 28, 2023 11:04
@Remi-Gau Remi-Gau changed the title [MAINT] update DOI [MAINT] update DOI and add RRID Oct 28, 2023
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@ymzayek ymzayek merged commit 5e27077 into nilearn:main Oct 30, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the doi branch October 30, 2023 08:46
@Remi-Gau
Copy link
Collaborator Author

Looks like I messed up the badge in the readme, no?

@ymzayek
Copy link
Member

ymzayek commented Oct 30, 2023

Ah yup just needs svg at the end I think. Want me to take care of it?

@Remi-Gau
Copy link
Collaborator Author

Would you mind?

@Remi-Gau
Copy link
Collaborator Author

Was thinking of using **kwargs

Do we have a policy on this?

@ymzayek
Copy link
Member

ymzayek commented Oct 30, 2023

Would you mind?

No problem

Remi-Gau added a commit to Remi-Gau/nilearn that referenced this pull request Nov 9, 2023
* update DOI

* update which DOI is used and add RRID
Remi-Gau added a commit that referenced this pull request Dec 9, 2023
* remove leading underscore from non private functions

* rm underscores in datasets

* rm underscores in decoding

* update script

* rename module

* rm more leading underscore from decoding mass_univariate datasets

* rename module

* move functions

* add doc string

* rename functions

* rename function

* Update doc/changes/0.10.1.rst

* flake8

* fix

* Update nilearn/signal.py

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>

* typo (#4091)

* [MAINT] update DOI and add RRID (#4032)

* update DOI

* update which DOI is used and add RRID

* [DOC] mention checking badges during release (#4085)

* [MAINT] Fix Zenodo DOI badge (#4093)

* pre-commit hooks auto-update (#4097)

Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com>

* Remove extraneous hash symbols (#4096)

* [DOC] Improve docstring rendering for typed experimental surface module (#4049)

* Correct linking

* Fix note

* Add tagging (#4100)

* [FIX] Disable extrapolation of out-of-bounds volumes (#4028)

* expose CubicSpline extrapolate parameter (#4028)

* [FIX] discard non-interpolated volumes and reset the sample_mask indexes

* [REF] discard non-interpolated volumes and reset sample_mask in '_handle_scrubbed_volumes'

* [FMT] black formatting

* improve deprecation warning message

* check that extrapolation warning is raised

* add changelog and contribution entries

* check consistency of modified sample_mask

* assert modified sample_mask can be applied to signals and confounds

* [REF] split signal extrapolation testing in 2 tests

* [BOT] update AUTHORS.rst and doc/changes/names.rst (#4102)

Co-authored-by: ymzayek <ymzayek@users.noreply.github.com>

* [MAINT] Add listing utilities (#2991)

* Add listing utilities

* Add possibility to filter by modules

* Add some tests

* Fix PEP8

* Clarify ignored modules by default

* Add section on Nilearn API in the user guide

* Export at the end

* [circle full] Add whats new

* revert

* more revert

* lint

* fix tests

* lint

* adapt tests to check number of public functions and classes

* update doc strings

* fix

---------

Co-authored-by: Remi Gau <remi_gau@hotmail.com>

* fix number of functions

* adapt number of functions

* update changelog

---------

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com>
Co-authored-by: Jordi Huguet <jhuguetn@gmail.com>
Co-authored-by: ymzayek <ymzayek@users.noreply.github.com>
Co-authored-by: Gensollen <nicolas.gensollen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Nilearn RRID should be mentioned in the doc
3 participants