New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Remove extraneous hash symbols for examples' section splitters #4096
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4096 +/- ##
==========================================
- Coverage 91.59% 91.51% -0.09%
==========================================
Files 143 143
Lines 16079 16079
Branches 3340 3340
==========================================
- Hits 14728 14714 -14
- Misses 804 819 +15
+ Partials 547 546 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I am pretty sure that you did it well but I messed up revolving a merge conflict related to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
* remove leading underscore from non private functions * rm underscores in datasets * rm underscores in decoding * update script * rename module * rm more leading underscore from decoding mass_univariate datasets * rename module * move functions * add doc string * rename functions * rename function * Update doc/changes/0.10.1.rst * flake8 * fix * Update nilearn/signal.py Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com> * typo (#4091) * [MAINT] update DOI and add RRID (#4032) * update DOI * update which DOI is used and add RRID * [DOC] mention checking badges during release (#4085) * [MAINT] Fix Zenodo DOI badge (#4093) * pre-commit hooks auto-update (#4097) Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com> * Remove extraneous hash symbols (#4096) * [DOC] Improve docstring rendering for typed experimental surface module (#4049) * Correct linking * Fix note * Add tagging (#4100) * [FIX] Disable extrapolation of out-of-bounds volumes (#4028) * expose CubicSpline extrapolate parameter (#4028) * [FIX] discard non-interpolated volumes and reset the sample_mask indexes * [REF] discard non-interpolated volumes and reset sample_mask in '_handle_scrubbed_volumes' * [FMT] black formatting * improve deprecation warning message * check that extrapolation warning is raised * add changelog and contribution entries * check consistency of modified sample_mask * assert modified sample_mask can be applied to signals and confounds * [REF] split signal extrapolation testing in 2 tests * [BOT] update AUTHORS.rst and doc/changes/names.rst (#4102) Co-authored-by: ymzayek <ymzayek@users.noreply.github.com> * [MAINT] Add listing utilities (#2991) * Add listing utilities * Add possibility to filter by modules * Add some tests * Fix PEP8 * Clarify ignored modules by default * Add section on Nilearn API in the user guide * Export at the end * [circle full] Add whats new * revert * more revert * lint * fix tests * lint * adapt tests to check number of public functions and classes * update doc strings * fix --------- Co-authored-by: Remi Gau <remi_gau@hotmail.com> * fix number of functions * adapt number of functions * update changelog --------- Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Remi-Gau <Remi-Gau@users.noreply.github.com> Co-authored-by: Jordi Huguet <jhuguetn@gmail.com> Co-authored-by: ymzayek <ymzayek@users.noreply.github.com> Co-authored-by: Gensollen <nicolas.gensollen@gmail.com>
Relates to #4031
which I did too quickly it seems