[ENH] Allow pandas.Series as valid input for second_level_input #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
TODO
|
Codecov Report
@@ Coverage Diff @@
## main #4070 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 143 143
Lines 16072 16077 +5
Branches 3339 3341 +2
=======================================
+ Hits 14722 14727 +5
Misses 804 804
Partials 546 546
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Remi-Gau
added a commit
to Remi-Gau/nilearn
that referenced
this pull request
Oct 24, 2023
…arn#4070) * support panda Series for scd lvl input * Update nilearn/glm/tests/test_second_level.py Co-authored-by: bthirion <bertrand.thirion@inria.fr> * fix test for errors * update changelog * typo --------- Co-authored-by: bthirion <bertrand.thirion@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: