New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] render reports in the documentation #4267
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
==========================================
+ Coverage 91.85% 92.09% +0.24%
==========================================
Files 144 143 -1
Lines 16419 16412 -7
Branches 3434 3438 +4
==========================================
+ Hits 15082 15115 +33
+ Misses 792 758 -34
+ Partials 545 539 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GLM examples would be listed in the reporting part of the API section: The GLM reports example page would look like this: |
If we generate the GLM reports on every doc build it would add 4 minutes to the doc build time: https://github.com/nilearn/nilearn/actions/runs/7888150339/job/21524981188?pr=4267#step:34:1588 Probably only worth doing on main or when requesting a |
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
@@ -1,57 +1,63 @@ | |||
"""Contain a bunch of functions run via __main__(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can we see the result of this build ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be viewable if we ask for a full build of the doc in the PR otherwise it will be build only after a full build in main?
https://nilearn.github.io/stable/development.html#building-documentation
git commit --allow-empty -m "[full doc] request full build"
Will trigger a full build on this PR.
Do you think that this should be treated like the examples, that is we trigger a build of only the examples that have been touched by a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to view the GLM reports as part of the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that this should be treated like the examples, that is we trigger a build of only the examples that have been touched by a PR?
Makes sense to me.
Changes proposed in this pull request: