New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] make masker report tables horizontally scrollable and not overlap with masker report images #4308
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside one small glitch, it is very hard to say anything on this.
Can you point to some generated outputs ?
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
Once #4295 is in I will ask for a full build of the doc so we can all easily check the reports. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
==========================================
+ Coverage 91.85% 92.12% +0.27%
==========================================
Files 144 143 -1
Lines 16419 16438 +19
Branches 3434 3444 +10
==========================================
+ Hits 15082 15144 +62
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* fix several issues in glm reports * further fixes * change cmap for glass brain * fix remaining issues * [full doc] request full build * update changelog * [full doc] request full build
… when not a `string` (nilearn#4297) * for views to be pairs of int or float when not a string * update changelog
* fix cut position in nifti maps maskers * update changelog
* remove conftest tempita * ignore tempita in pyproject.toml
* add script to check duration of test suite * add comment * comment and refactor * typo * improve paging * add workflow * Update maint_tools/requirements.txt * fail on bad request * upload artefacts * upload artefacts * remove running on PR * Apply suggestions from code review Co-authored-by: Elizabeth DuPre <emd222@cornell.edu> * update doc string * update doc string * refactor --------- Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
* display masker reports in doc * update changelog * refactor * add notebooks * clear cells * [full doc] request full build * add link to examples * [full doc] request full build * fix doc build
For reviewBefore (current dev doc)
After |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
Changes proposed in this pull request: