Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove temDir after we done copy. Unnecessary duplicate #65

Open
mozinrat opened this issue Oct 2, 2017 · 4 comments
Open

Should remove temDir after we done copy. Unnecessary duplicate #65

mozinrat opened this issue Oct 2, 2017 · 4 comments

Comments

@mozinrat
Copy link

mozinrat commented Oct 2, 2017


Post this line we should have tmpDir.deleteDir()
Else in buildDir we see duplicate folder of generated-src and wsdl2Java.

Opened PR #66 for the same

@SavcuksMihails
Copy link

Hi,

Having the same problem - regardless of generatedWsdlDir option value, plugin ALWAYS generates (in build directory) additional (redundant) folder with name= "wsdl2java", that contains another folder with strange name (md5?) = "31c309a3eeb5ad487dc5633ddfe1ebc4" and deeper by hierarchy, where java files live.

Like that:
image

Nothing can do with that...
Is it planned to fix that?

@jskov-jyskebank-dk
Copy link
Collaborator

Why is it a problem? The build folder contains transient data. It is just trash.

@SavcuksMihails
Copy link

Maybe its not a problem indeed. Just a bit weird to see duplicated data. By investigating plugin code, I thought that plugin developer just forgot to delete this folder (as described in initial issue comment).

@jskov-jyskebank-dk
Copy link
Collaborator

Gradle uses the content of the output folder to determine if a task need to be executed.

So if the build output folder is removed (or its contents changed), the task will run again.

One could generate the output directly to the desired target folder.
But then Gradle would hash everything in that folder to determine if the task needed to run.
Also files not related to the task. So the task may have to re-run after unrelated side-effects to the target directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants