-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asynchttpserver form data/body broken with #13147 #13361
Comments
But #13146 wasn't merged (it's closed)? |
Sorry, relied on Github's inline preview menu and didn't notice the duplicate. |
Sorry, but, my first proposal didn't break anything, you can see the code here: . 4fdbf8f But Dominik Picheta asked me if I could implement it with Future Streams. Yes, with Future Streams it break the things. But, now you can upload large files without exhaust all resources ;-) |
Rosencrantz was also broken recently, I am going to check if this is the reason |
|
Actually the promise is two-fold:
And yeah, it means we need to revert the PR that introduced the problem. |
Cool! I had missed that, and in fact Rosencrantz still works with that flag :-) |
Please, check the fix for this issue: #13394 |
#13147 claims it does not break anything (and states it's an option), but it broke Jester's form data handling. Since there is a transition from body to bodyStream, this might have been intended.
nim c -d:useStdLib test.nim
curl -d 'q=foo' http://localhost:5000
With devel:
{:}
Before the change:
{"q": "foo"}
The Jester code responsible for getting the form data is not easily modifiable to support this change as it's non-async and relies on the old
body
field which is now useless.The text was updated successfully, but these errors were encountered: