parser accepts invalid indentation in parenthesized expression

[timotheecour]

found in #18498

Example

let temp = (
  if true:
    1
else:  # <------ unindented
    discard nil
    2
)

Current Output

compiles

Expected Output

CT error because of indentation

Additional Information

1.5.1 12da32a

[Clyybber]

That is specific to if and when expressions and intentional.

let temp = if true:
    1
else:  # <------ unindented
    discard nil
    2

[timotheecour]

this doesn't make sense. there is no valid practical purpose to allow code like this:

when true:
  (
    if true:
      echo 1
elif true:
      echo 2
     else:
      echo 3
  )

and as you can see here, it breaks consistency, eg if you replace echo(2) by if true: echo(2) it stops working:

when true:
  (
    if true:
      echo 1
elif true:
  # echo(2) # works
  if true: echo(2) # fails
  )

instead of closing immediately, let others chime in at least for a few days

parenthesized should allow useful things like #8258, but not random code like above