-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Semi-regression] C code contains backtick`gensym #23711
Comments
Also it's important to note that some errors are generated even in files with no The z_NEQ variable comes from this template: and the top of the file pushes |
mratsim
changed the title
C code contains backtick`gensym
[Semi-regression] C code contains backtick`gensym
Jun 12, 2024
ringabout
added a commit
that referenced
this issue
Jun 13, 2024
Araq
pushed a commit
that referenced
this issue
Jul 17, 2024
This adds Constantine to the important packages. Release announcements: - https://forum.nim-lang.org/t/11935 - https://github.com/mratsim/constantine/releases/tag/v0.1.0 Unfortunately at the moment I'm in a conundrum. - Constantine cannot compile on devel due to #23547 - The workaround is changing ```Nim func mulCheckSparse*(a: var QuadraticExt, b: static QuadraticExt) {.inline.} = ``` to ```Nim template mulCheckSparse*(a: var QuadraticExt, b: QuadraticExt) = ``` but this does not compile on v2.0.8 due to `gensym` issues despite #23716 ![image](https://github.com/nim-lang/Nim/assets/22738317/21c875d7-512f-4c21-8547-d12534e93a58). i.e. as mentioned in the issue #23711 there is another gensym bug within templates that was fixed in devel but not the v2.0.x series and that is not fixed by #23716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in Discord at https://discord.com/channels/371759389889003530/768367394547957761/1250440092208730152
Using the latest
version2-0
branch I have a regression compared to 2.0.4 that leads to backtick of gensym'ed symbols not being translated to X60 as usual due to #22944 being backported.See CI run: https://github.com/mratsim/constantine/actions/runs/9471919674/job/26096274691?pr=393#step:23:47
It seems to also lead to conflicting types using same name variables
https://github.com/mratsim/constantine/actions/runs/9471919674/job/26096274691?pr=393#step:23:13
Reproducing
Note that gcc-14 has issues that might not be backported yet so it's easier to use Clang (https://github.com/nim-lang/Nim/pulls?q=is%3Apr+%22gcc+14%22+is%3Aclosed+ )
Similar bug
If it helps, in the past I used to have those issues in v2.0.4, but only in templates and only with
{.noInit.}
variables.I found 2 workarounds:
Unfortunately I tried to minimize the issue to a single file and failed at the time.
The text was updated successfully, but these errors were encountered: