Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koch pdf produces a warning about unknown substitution 'nimversion' #23846

Closed
EuklidAlexandria opened this issue Jul 16, 2024 · 0 comments · Fixed by #23847
Closed

koch pdf produces a warning about unknown substitution 'nimversion' #23846

EuklidAlexandria opened this issue Jul 16, 2024 · 0 comments · Fixed by #23847

Comments

@EuklidAlexandria
Copy link
Contributor

Description

When compiling the PDF documentation with koch pdf the string |nimversion| in the Markdown files is not substituted.

Nim Version

Nim Compiler Version 2.0.8 [Linux: amd64]
Compiled at 2024-07-03
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: 5935c3b
active boot switches: -d:release

Current Output

nim-2.0.8-linux_x64/nim-2.0.8/doc/manual.md(6, 12) Warning: unknown substitution 'nimversion' [UnknownSubstitutionX]

Expected Output

No response

Possible Solution

It seem like the environment variable nimversion does not get correctly passed. Probably, changing the procedure signature buildPdfDoc*(nimArgs, destPath: string) to buildPdfDoc*(args: string, destPath: string) in tools/kochdocs.nim and adding let args = nimArgs & " " & args to the body (as in buildDocsDir) would fix it.

Additional Information

No response

EuklidAlexandria added a commit to EuklidAlexandria/Nim that referenced this issue Jul 16, 2024
EuklidAlexandria added a commit to EuklidAlexandria/Nim that referenced this issue Jul 17, 2024
EuklidAlexandria added a commit to EuklidAlexandria/Nim that referenced this issue Jul 17, 2024
ringabout pushed a commit that referenced this issue Jul 17, 2024
Fixes #23846. Probably, nimArgs should be prepended in other places
(e.g. `buildDocSamples`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant