Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support endpoint_url in S3 client constructor #17

Closed
jthomas opened this issue Jul 29, 2021 · 1 comment
Closed

Support endpoint_url in S3 client constructor #17

jthomas opened this issue Jul 29, 2021 · 1 comment
Assignees
@jthomas
Labels
enhancement New feature or request

Comments

@jthomas
Copy link
Contributor

jthomas commented Jul 29, 2021

If you want to use the S3 storage client with a newer region - we need to explicitly set the endpoint_url parameter in the client config. This is an undocumented "feature" of the S3 service. boto/boto3#2728

We should also change the presigned url API parameters to be more generic. Rather than having an explicit "ContentType" - allow users to pass in any parameters they want. This will make it easier to decouple the implementation of the storage API from the providers API.
@jthomas jthomas added the enhancement New feature or request label Jul 29, 2021
@jthomas jthomas self-assigned this Jul 29, 2021
@jthomas
Copy link
Contributor Author

jthomas commented Jul 30, 2021

https://github.com/nimbella/nimbella-sdk-python/pull/18/files

@jthomas jthomas closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jthomas jthomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jthomas