This repository has been archived by the owner on Sep 23, 2020. It is now read-only.
This request adds hints to the sensor UI. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this commit requires patching bootstrap Typeahead to support showing the typeahead when no text has been entered yet.
oldpatricka
added a commit
that referenced
this pull request
Feb 5, 2013
This request adds hints to the sensor UI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this uses a static list of sensors, which we can update occasionally.
This is mostly because OpenTSDB only supports pulling 25 sensors at a time from
its API (the /suggest URL). To be able to get all of them will require patching
OpenTSDB.
Also note the patch to Bootstrap's typeahead support. This allows showing the
hints when no characters have been typed yet.