Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEB package includes dev dependencies #603

Closed
2 tasks done
josefschabasser opened this issue Aug 25, 2021 · 1 comment · Fixed by #630
Closed
2 tasks done

DEB package includes dev dependencies #603

josefschabasser opened this issue Aug 25, 2021 · 1 comment · Fixed by #630
Assignees

Comments

@josefschabasser
Copy link
Contributor

New issue checklist

General information

  • Library version(s): latest DEB package
  • Browser version(s):
  • Devices/Simulators/Machine affected:
  • Reproducible in the testnet? (Yes/No):
  • Related issues:

Bug report

Expected behavior

DEB package does not include dev dependencies

Actual behavior

DEB package includes dev dependencies

Steps to reproduce

install DEB package or build docker image and inspect /usr/share/nimiq/app/node_modules
theres typescript (52MB), babel (18MB) and others inside, which shouldn't be there.

Question or Feature Request

This is more of a feature request, dev dependencies shouldn't be shipped with a prebuilt package.
This would reduce installation size from 178 MB to 26 MB.

@jeffesquivels
Copy link
Member

This should be solved now with only one dev dependency remaining in the packages (see #630 for details) which should be fixed once we move to different tooling for creating deb packages (#629).

Thank you very much for reporting this, @josefschabasser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants