Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'/balance' command shouldn't be executed by console #48

Closed
MCUmbrella opened this issue Jan 12, 2022 · 1 comment · Fixed by #49
Closed

'/balance' command shouldn't be executed by console #48

MCUmbrella opened this issue Jan 12, 2022 · 1 comment · Fixed by #49
Assignees
Labels
bug Something isn't working

Comments

@MCUmbrella
Copy link

Describe the bug
The plugin is missing necessary sender type check when performing player-only commands. When the /bal command is executed by the console the plugin will throw ClassCastException

To Reproduce
Steps to reproduce the behavior:

  1. Type /bal in the console
  2. See error

Expected behavior
The plugin denied to perform the command and print an error message (e.g. "This command is player-only")

Screenshots
Not needed

Server Info (please complete the following information):
—OS: Linux
— Java: openjdk version "11.0.13" 2021-10-19 LTS
—Version 0.0.10

CCLogs
Not needed

Server logs
https://www.toptal.com/developers/hastebin/ivocusopot.properties

Additional context
None

@MCUmbrella MCUmbrella added the bug Something isn't working label Jan 12, 2022
@NinekoTheCat
Copy link
Owner

Thank you for writing about this bug, I will get to fixing it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants