Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score value ease-out fix #447

Closed
wants to merge 2 commits into from
Closed

Conversation

vinjcc
Copy link

@vinjcc vinjcc commented Feb 17, 2021

redoing because i thought i could learn git and now i am experiencing hell

tiny fix so that when the week score transitions from a smaller value to a greater one, it reaches the intended value. currently, if the score tries going up to a value like 10300, it gets stuck at 10299.
also changed the free play menu score's lerp ratio to be 0.5 like the story menu, just for some uniformity idk

@PrincessMtH
Copy link
Contributor

freeplay already has code that jumps lerpscore to intendedscore so the added code there is redundant, might be better to just copy that over to the week score stuff instead lol

@vinjcc
Copy link
Author

vinjcc commented Mar 29, 2021

you mean if (Math.abs(lerpScore - intendedScore) <= 10) lerpScore = intendedScore;? i think i was going to remove it but forgot, oops. could have copied it to storymenu but i prefer jumping when diff=1 rather than 10, even though it doesn't matter that much.

@vinjcc
Copy link
Author

vinjcc commented Apr 3, 2021

closing this because i found a cleaner solution that circumvents all floating point rounding nonsense

@vinjcc vinjcc closed this Apr 3, 2021
kudorado pushed a commit to kudorado/Funkin that referenced this pull request Jul 18, 2021
Preparations to 1.4.3, add Patch Notes to Outdated screen and others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants