Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop compiling protoc from source #34

Closed
ninjudd opened this issue Jul 12, 2012 · 4 comments
Closed

Stop compiling protoc from source #34

ninjudd opened this issue Jul 12, 2012 · 4 comments

Comments

@ninjudd
Copy link
Owner

ninjudd commented Jul 12, 2012

Instead of compiling protoc from source, we should have users install protobuf using the package manager for their OS (brew, yum, etc...).

We may still have to download the Java source though, right @Raynes.

@ghost ghost assigned Raynes Jul 12, 2012
@ninjudd
Copy link
Owner Author

ninjudd commented Jul 12, 2012

/assign @Raynes

@Raynes
Copy link
Contributor

Raynes commented Jul 12, 2012

It looks like we extract some protos from the source distribution for our top-level protobuf project itself, so this isn't something we'll need to do for an end-user.

@ninjudd
Copy link
Owner Author

ninjudd commented Jul 12, 2012

Great. So we can only download the source when building clojure-protobuf itself.

We should have a good error message for the user when protoc is not available though. Something like:

Could not find protoc on your path. You need to install it using your favorite package manager.
Try one of the following:
    brew install protobuf
    yum install protobuf
Or install it from source: http://code.google.com/p/protobuf/downloads/list

@ninjudd
Copy link
Owner Author

ninjudd commented Jul 17, 2012

We changed our minds about this. Instead, we still compile protoc from source, we just don't install it using sudo.

@ninjudd ninjudd closed this as completed Jul 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants