Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login username placeholder to only request "user" instead of "email" #56

Closed
binarydad opened this issue May 30, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@binarydad
Copy link

As mentioned in #53, the full user@domain is no longer required, so it seems fitting that the field placeholder also matches.

image

@nioc
Copy link
Owner

nioc commented May 31, 2022

As mentioned in my last comment, user can either login with just local jid (using default domain) or full jid.
Some users requested a feature for setting custom websocket transport url.
I think it is easier to understand if placeholder mention xmpp domain.

What I can do is to set the domain in placeholder with the default domain instead of hard-coded one.

@nioc nioc added the enhancement New feature or request label May 31, 2022
@nioc nioc self-assigned this May 31, 2022
@nioc nioc closed this as completed in 34d1600 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants