Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned MUCs in channel-list? #87

Closed
poVoq opened this issue Feb 1, 2023 · 6 comments
Closed

Pinned MUCs in channel-list? #87

poVoq opened this issue Feb 1, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@poVoq
Copy link

poVoq commented Feb 1, 2023

Intended behavior

It can be a bit confusing for non-techy users to find the right place on joining first and seeing the unsorted list on channels to join. This is mainly for the guess access.

Solution

There could be an option to pin 1-2 specific MUCs to the top of the list that are highlighted for new users to join.

Thanks!

Alternatives

No response

Priority

Should-have

Users scope

guests

Affected features

rooms list

Pull request

no

@poVoq poVoq added the enhancement New feature or request label Feb 1, 2023
@nioc
Copy link
Owner

nioc commented Feb 1, 2023

Do you think there is a way to flag some rooms server side (through XMPP service discovery or other stuff)?

Alternatively, we can display rooms order by name in guest/rooms page (actually, there is no sorting rules). So XMPP admin can name them smartly for ordering 😉

@Ppjet6
Copy link
Contributor

Ppjet6 commented Feb 1, 2023

So it seems many clients actually do pinning. I've opened https://codeberg.org/joinjabber/support/issues/5 to keep track of progress in the community. There is certainly something to be done in the standard.

If we're only talking about JoinJabber, doing XEP-0469, only usable with bookmarks2, and add default bookmarks for anonymous users, I guess it would work. As XMPP Web seems to be handling bookmarks even for guests.

@nioc
Copy link
Owner

nioc commented Feb 1, 2023

I'm confused about set default bookmark.
Maybe, is should be easier to add a local.js attribute with pinned rooms list?

@poVoq
Copy link
Author

poVoq commented Feb 1, 2023

Yeah, that is what I actually thought first. Simply add a comma separated list of pinned room JIDs to the xmpp-web config file and do the filtering and sorting client side in JS. Ideally this could include an option to hide all non-pinned/featured rooms unless someone uses the search to find additional chats.

Pinned default bookmarks sounds like a good idea, but AFAIK the room list is a discovery query on the default muc-component and thus has nothing to do with bookmarks directly, right?

@Ppjet6
Copy link
Contributor

Ppjet6 commented Feb 1, 2023

the room list is a discovery query on the default muc-component and thus has nothing to do with bookmarks directly, right?

Currently yeah that's how it's handled in XMPP Web, disco#items, but it also queries for bookmarks anyway.

I'm confused about set default bookmark.

It's possible for the XMPP server to pre-configure a list of bookmarks for accounts.
In Prosody for example there is mod_default_bookmarks. It doesn't seem to handle pinned bookmarks but "it shouldn't be too hard".

@nioc
Copy link
Owner

nioc commented Feb 1, 2023

Ok, I handle a local.js rooms list to pinned in this issue. I will also add a room name order (I feel more comfortable with it than the "first received from server, first displayed").
If you want to explore the bookmark way, I let you open another issue (I think both approaches are interesting).

@nioc nioc self-assigned this Feb 1, 2023
@nioc nioc added this to the 0.9.7 milestone Feb 1, 2023
@nioc nioc closed this as completed in 65ec4b8 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants