Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load older events/history in conversation view #16

Closed
kiliankoe opened this issue Nov 26, 2019 · 3 comments · Fixed by #246
Closed

Load older events/history in conversation view #16

kiliankoe opened this issue Nov 26, 2019 · 3 comments · Fixed by #246
Labels
essential Features absolutely necessary for a functioning messaging app

Comments

@kiliankoe
Copy link
Member

Ideally on demand when reaching the top of the scroll view. But more events than are shown currently should be shown by default as well.
@kiliankoe kiliankoe added the essential Features absolutely necessary for a functioning messaging app label Nov 26, 2019
@kiliankoe kiliankoe mentioned this issue Apr 9, 2020
Closed
stefanhofman added a commit that referenced this issue Apr 30, 2020
@stefanhofman
Update paginate messages
3cd0e2f 
Changed the ScrollView to a List view, because .onAppear does not work well on ScrollViews
#16
@stefanhofman
Copy link
Member

I tried implementing 3cd0e2f fetching new messages when you scroll to the top, but I got stuck. New messages are coming in, but they are not being displayed... @kiliankoe maybe you can take a look and spot the problem.

@kiliankoe
Copy link
Member Author

Whoa, tackling the most important stuff! 😄 I'm somewhat scared of this issue, I've tried it several times, but just haven't found a way to do it yet. I'll definitely have a look!

@kiliankoe
Copy link
Member Author

I've started refactoring all of the current message handling, all of that was more or less based on me guessing how the SDK works. Just as a head's up, most if not all of the current AccountStore has to go, it doesn't really lend itself well to how this should be handled.

@kiliankoe kiliankoe changed the title Load older events in conversation view Load older events/history in conversation view Jan 18, 2021
@kiliankoe kiliankoe mentioned this issue Jan 18, 2021
Closed
pixlwave pushed a commit that referenced this issue Feb 6, 2021
@stefanhofman @pixlwave
Update paginate messages
8c6d8b4 
Changed the ScrollView to a List view, because .onAppear does not work well on ScrollViews
#16
@kiliankoe kiliankoe linked a pull request Feb 13, 2021 that will close this issue
Load more messages #246
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
essential Features absolutely necessary for a functioning messaging app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load more messages niochat/nio
2 participants
@kiliankoe @stefanhofman