Load more messages #246
Merged
Load more messages #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the ScrollView to a List view, because .onAppear does not work well on ScrollViews #16
…ith non-fixed height elements. Add a loading spinner to ReverseList and when it's in frame load more messages.
pixlwave
commented
Feb 11, 2021
|
omg :O The changes look great and it works really well! Passing up the visibility through the preference key is so cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be working well for me. @stefanhofman's original pagination implementation is great, all that I've done is reverted back to a regular
VStack(after trying aLazyVStack) as it doesn't seem to be recommended to use a list or lazy stack for content with variable content size (also it doesn't seem possible to hide the table view separators on aListsince iOS 14 so that was a dead end).I added a
ProgressViewspinner at the top of the list which triggers the pagination whenever it comes into view. Needs some future work to hide the spinner if there's no more messages to load.