Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] add ceagent to figures.json #479

Closed
wants to merge 6 commits into from
Closed

Conversation

jdkent
Copy link
Collaborator

@jdkent jdkent commented Mar 18, 2020

@pull-assistant
Copy link

pull-assistant bot commented Mar 18, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     replace ce with ceagent

     test ceagent

     add ceagent as needed_entity for tests

     ensure one file per reportlet

     change dir to direction

     change expected size of output

Powered by Pull Assistant. Last update 090aee4 ... d54de66. Read the comment docs.

@jdkent
Copy link
Collaborator Author

jdkent commented Mar 18, 2020

dir should also be direction

@oesteban
Copy link
Member

dir should also be direction

Do you want to address that in this PR?

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #479 into master will decrease coverage by 5.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   62.86%   57.68%   -5.19%     
==========================================
  Files          41       40       -1     
  Lines        4993     4979      -14     
  Branches      724      723       -1     
==========================================
- Hits         3139     2872     -267     
- Misses       1703     1979     +276     
+ Partials      151      128      -23     
Flag Coverage Δ
#documentation ?
#reportlettests ?
#travis 57.68% <100.00%> (-0.03%) ⬇️
#unittests ?
Impacted Files Coverage Δ
niworkflows/reports/core.py 72.09% <100.00%> (-0.48%) ⬇️
niworkflows/func/util.py 25.00% <0.00%> (-62.50%) ⬇️
niworkflows/anat/ants.py 12.15% <0.00%> (-57.46%) ⬇️
niworkflows/anat/freesurfer.py 39.13% <0.00%> (-52.18%) ⬇️
niworkflows/anat/skullstrip.py 30.00% <0.00%> (-50.00%) ⬇️
niworkflows/interfaces/itk.py 26.92% <0.00%> (-12.31%) ⬇️
niworkflows/interfaces/fixes.py 41.17% <0.00%> (-11.77%) ⬇️
niworkflows/interfaces/bids.py 80.15% <0.00%> (-10.32%) ⬇️
niworkflows/interfaces/ants.py 57.81% <0.00%> (-7.82%) ⬇️
niworkflows/interfaces/utils.py 37.76% <0.00%> (-4.99%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfffaf8...d54de66. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants