[FIX] Add CE agent to output figure filename templates #482
Conversation
|
Best reviewed: commit by commit
Optimal code review plan
|
| @@ -21,15 +21,15 @@ | |||
| "pattern": "[_/\\\\]acq-([a-zA-Z0-9]+)" | |||
| }, | |||
| { | |||
| "name": "ce", | |||
| "name": "ceagent", | |||
There was a problem hiding this comment.
Does this have any API effect?
There was a problem hiding this comment.
No, I do not believe so. This does not impact the recently added --bids-filter, and makes figures.json naming consistent with fmriprep.yml.
There was a problem hiding this comment.
Okay. @oesteban Is this consistent with your understanding as well?
There was a problem hiding this comment.
Yup, I also think this should not affect the API
|
Actually, since #479 isn't merged, let's just make this the main PR, and we'll merge into |
effigies
changed the title
Codecov Report
@@ Coverage Diff @@
## maint/1.1.x #482 +/- ##
===============================================
- Coverage 62.93% 57.76% -5.18%
===============================================
Files 41 40 -1
Lines 5005 4991 -14
Branches 727 726 -1
===============================================
- Hits 3150 2883 -267
- Misses 1704 1980 +276
+ Partials 151 128 -23
Continue to review full report at Codecov.
|
|
I've tested with a synthetic dataset where I switched from Given @bbfrederick's comments, I'm going to go ahead and merge. Thanks! |
|
Works for me. I'll wait until the dust settles, sync up with the patched release version of niworkflows, and then put in a PR for the BIDS_NAME thing. AFAIK it doesn't actually cause any problems at the moment, but it is wrong and it might bite somebody later if they decide to use it, so it's not currently urgent. |
20.0.5 (March 19, 2020) Bug-fix release in 20.0.x series. With thanks to James Kent for the fix and Blaise Frederick for the report and testing. * FIX: Add CE agent to output figure filename templates (nipreps/niworkflows#482)
supercedes #479
addresses nipreps/fmriprep#2033