Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] update naming patterns in figures.json #483

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

jdkent
Copy link
Collaborator

@jdkent jdkent commented Mar 19, 2020

two items that I thought should be changed:

  • contrast -> ceagent in the anatomical default_path_patterns
  • remove _bold from echo pattern, (I'm not sure what the original intention of the pattern was, but the double backslash does not appear to match a reasonable string, and echo is not required to be the last key-value pair in the default_path_patterns)

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     contrast -> ceagent; remove _bold from echo pattern

Powered by Pull Assistant. Last update 7edd0fb ... 7edd0fb. Read the comment docs.

@effigies
Copy link
Member

I think it was probably supposed to be _bold\\., but I agree that it doesn't make sense in this context.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #483 into maint/1.1.x will decrease coverage by 5.15%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.1.x     #483      +/-   ##
===============================================
- Coverage        62.91%   57.76%   -5.16%     
===============================================
  Files               41       40       -1     
  Lines             5002     4991      -11     
  Branches           726      726              
===============================================
- Hits              3147     2883     -264     
- Misses            1704     1980     +276     
+ Partials           151      128      -23     
Flag Coverage Δ
#documentation ?
#reportlettests ?
#travis 57.76% <ø> (ø)
#unittests ?
Impacted Files Coverage Δ
niworkflows/func/util.py 25.00% <0.00%> (-62.50%) ⬇️
niworkflows/anat/ants.py 12.15% <0.00%> (-57.46%) ⬇️
niworkflows/anat/freesurfer.py 39.13% <0.00%> (-52.18%) ⬇️
niworkflows/anat/skullstrip.py 30.00% <0.00%> (-50.00%) ⬇️
niworkflows/interfaces/itk.py 26.92% <0.00%> (-12.31%) ⬇️
niworkflows/interfaces/fixes.py 41.17% <0.00%> (-11.77%) ⬇️
niworkflows/interfaces/bids.py 80.15% <0.00%> (-10.32%) ⬇️
niworkflows/interfaces/ants.py 57.81% <0.00%> (-7.82%) ⬇️
niworkflows/interfaces/utils.py 37.76% <0.00%> (-4.99%) ⬇️
niworkflows/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2b5f3...7edd0fb. Read the comment docs.

@jdkent jdkent requested a review from oesteban March 19, 2020 16:15
@effigies effigies merged commit 3b8bab2 into nipreps:maint/1.1.x Mar 19, 2020
effigies added a commit that referenced this pull request Mar 19, 2020
1.1.12 (March 19, 2020)

Bug-fix release in the 1.1.x series.

* FIX: Update naming patterns in figures.json (#483)
* FIX: Add CE agent to output figure filename templates (#482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants