Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Relax rotation threshold #167

Merged
merged 2 commits into from
Apr 8, 2013

Conversation

matthew-brett
Copy link
Member

Relax threshold for orthogonality of rotation matrix.

I propose this pull request to replace #157 and #156

Part of the discussion of the rotation matrix thresholds on githab at:
nipy#156
The threshold was probably too low for lower precision dicoms.

As discussed in nipy#156
@matthew-brett
Copy link
Member Author

Any comments here?

matthew-brett added a commit that referenced this pull request Apr 8, 2013
MRG: Relax rotation threshold

Relax threshold for orthogonality of rotation matrix to deal with low-precision values in DICOM Image Orient Patient field.
@matthew-brett matthew-brett merged commit 5006ed0 into nipy:master Apr 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant