diag = >diag.copy() when the matrix will be manipulated.

[bcipolli]

This is a general fix for #325 . In the newest version of numpy, when diag returns a vector of numbers along the diagonal, that vector is read-only. In places where we wish to manipulate the elements of that vector, we need to call copy() first.

I manually went through to check each call to diag, and to see where we manipulated the elements or returned the vector value.

Questions:

• Do we have tests that use numpy==1.9?
• Do we want to add a specific plotting regression for plot_map error with numpy 1.9 #325?

[matthew-brett]

The travis tests use latest numpy, as well as minimal numpy - is that enough?

If you feel like adding a plotting regression test, that would be very helpful.

[bcipolli]

OK, then we should beef up the test coverage before merging this PR--there should be multiple issues, not just the plotting one.

I'll take a look at that now.

[bthirion]

This PR looks good.

[matthew-brett]

Ben - where are we with this one?

[bcipolli]

Oops, I got sidetracked. I determined two of the changes were unnecessary, and that two of the changes are untested. I simply need to write tests for them.

I will do that now.

[bcipolli]

@matthew-brett most of the changes here were unnecessary. #325 had been fixed elsewhere, most of the changes I made here turned out to be irrelevant.

What's left is one final change, and it's basically untestable--requires Mayavi to be installed. So.. I think just take it as-is or dump it.

[matthew-brett]

Seems to have another PR In list of commits? Bad rebase maybe?

[bcipolli]

Re- rebased. Travis build is looking fine.

[matthew-brett]

Nice, thanks.