Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_olsR: use assert_array_almost_equal instead #381

Merged
merged 1 commit into from Nov 2, 2015

Conversation

ignatenkobrain
Copy link
Contributor

due to bug in numpy

Related: numpy/numpy#5200

due to bug in numpy

Related: numpy/numpy#5200
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@bthirion
Copy link
Contributor

bthirion commented Nov 1, 2015

  Dear Igor,

 The fix sounds right, but beware that nipy contains lots of dead 

code and is actually no longer developed.
Depending on your need, you might want to look at other projects.
Best,

Bertrand Thirion

@matthew-brett
Copy link
Member

Great - thanks for doing this. Looks good to me.

I will keep nipy in maintenance mode for at least another three years, probably five.

The code that you're testing here is I think already in nistats and will soon be in another package based on Jonathan Taylor's work for the current FMRI statistics stuff, and I can keep track of the correspondence for the second package - I guess Bertrand will be doing the same for nistats.

matthew-brett added a commit that referenced this pull request Nov 2, 2015
MRG: test_olsR: use assert_array_almost_equal instead

Workaround bug in numpy ``assert_almost_equal`.
@matthew-brett matthew-brett merged commit b85ba6b into nipy:master Nov 2, 2015
@ignatenkobrain
Copy link
Contributor Author

I'm packaging all projects related, so I'm working on packaging nistats also. There are problem with non compatible with new version of nilearn, but I hope this will be fixed soon.

@bthirion
Copy link
Contributor

bthirion commented Nov 3, 2015

It will, for sure. We were waiting for the next Nilearn release, to be compatible with release versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants