Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fixed failing doctest #406

Merged
merged 1 commit into from Aug 11, 2016
Merged

Conversation

bthirion
Copy link
Contributor

@bthirion bthirion commented Aug 5, 2016

Addresses #404

@coveralls
Copy link

coveralls commented Aug 5, 2016

Coverage Status

Coverage remained the same at 87.138% when pulling 32cb61e on bthirion:fix_mfx_doctest into f8d3149 on nipy:master.

@codecov-io
Copy link

Current coverage is 83.52% (diff: 100%)

Merging #406 into master will not change coverage

@@             master       #406   diff @@
==========================================
  Files           291        291          
  Lines         27757      27757          
  Methods           0          0          
  Messages          0          0          
  Branches       3252       3252          
==========================================
  Hits          23185      23185          
  Misses         3570       3570          
  Partials       1002       1002          

Powered by Codecov. Last update f8d3149...32cb61e

@matthew-brett
Copy link
Member

Sorry for my ignorance, but can you explain the change?

@bthirion
Copy link
Contributor Author

I removed the cases where the simulated effects are 0: In these cases, due to the constraint in l.376, the mfx test can be more variable then the classical Student alternative, leading to a failure of the docstring.

@matthew-brett
Copy link
Member

Thanks - that's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants