Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Migrate CircleCI tests to docker #1541

Merged
merged 33 commits into from
Jul 22, 2016
Merged

[TST] Migrate CircleCI tests to docker #1541

merged 33 commits into from
Jul 22, 2016

Conversation

oesteban
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage increased (+0.01%) to 72.335% when pulling 58dec59 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage increased (+0.006%) to 72.331% when pulling 8ff6d28 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage remained the same at 72.325% when pulling 8ff6d28 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling 8ff6d28 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling 3f80131 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling aadbbfe on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage increased (+0.01%) to 72.335% when pulling 2643f22 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage remained the same at 72.325% when pulling 2fb2dcb on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage remained the same at 72.325% when pulling 2fb2dcb on oesteban:tst/Docker into bd36a5d on nipy:master.

@satra
Copy link
Member

satra commented Jul 19, 2016

@oesteban - should we merge this? or will circle ci also build docker image from these dockerfiles?

@oesteban
Copy link
Contributor Author

@satra no, not yet. I am still fixing some final issues (i.e. sphinx was not installed). When the tests are equivalent to those we currently have I will remove the tag WIP in the title and let you know ;)

@coveralls
Copy link

coveralls commented Jul 19, 2016

Coverage Status

Coverage increased (+0.006%) to 72.331% when pulling b419995 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 19, 2016

Coverage Status

Coverage increased (+0.01%) to 72.335% when pulling fe1d01c on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 19, 2016

Coverage Status

Coverage increased (+0.01%) to 72.335% when pulling fe1d01c on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage increased (+0.01%) to 72.335% when pulling 3cb904e on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage remained the same at 72.325% when pulling 6247d12 on oesteban:tst/Docker into bd36a5d on nipy:master.

@oesteban
Copy link
Contributor Author

More tests are getting green :)

@satra, I have the impression that none of the tests uses the FSL course data. Do you remember if this is correct? It takes a while to download it and it'd be great if we could remove that dataset.

@satra
Copy link
Member

satra commented Jul 20, 2016

maybe this one does: https://github.com/nipy/nipype/blob/master/circle.yml#L57

from a certain perspective, unless we create a perfect matching workflow for feat, we can test on any data.

@oesteban
Copy link
Contributor Author

Well, that one uses the fsl feeds only, I guess... The fsl_course_data contains three data packages: fdt1, fdt2 and tbss. The three of them are for diffusion and all the test workflows are for fmri...

@satra
Copy link
Member

satra commented Jul 20, 2016

we should have feeds only then for now instead of everything.

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling ec55934 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage remained the same at 72.325% when pulling 2f78e69 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage decreased (-0.03%) to 72.293% when pulling 08b382f on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling 3fbb325 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling 1e37816 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+0.004%) to 72.329% when pulling 842b8b9 on oesteban:tst/Docker into bd36a5d on nipy:master.

@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage increased (+0.01%) to 72.335% when pulling 7b847b7 on oesteban:tst/Docker into bd36a5d on nipy:master.

@oesteban
Copy link
Contributor Author

All green now! Some final details and this will be ready for merge.

@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage increased (+0.006%) to 72.331% when pulling ffc06e9 on oesteban:tst/Docker into bd36a5d on nipy:master.

@oesteban oesteban changed the title [TST,WIP] Migrate CircleCI tests to docker [TST] Migrate CircleCI tests to docker Jul 22, 2016
@oesteban
Copy link
Contributor Author

oesteban commented Jul 22, 2016

@satra this is ready to be merged.

I expect to cut down a bit the 3h 30' it takes to run all the tests when the image caching starts to work. It seems that cache is taken from the master branch, and thus it is not working yet.

@satra satra merged commit 162dd7c into nipy:master Jul 22, 2016
@oesteban oesteban deleted the tst/Docker branch July 22, 2016 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants