FIX: Correctly pickle OuputMulti{Object,Path} traits
#2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that nipy#2944 has uncovered a rats-nest hidden in the engine. In resolving that issue, I found out that a great deal of boilerplate was set in place when loading/saving results to deal with ``OutputMulti{Object,Path}`` traits. The reason being that these traits flatten single-element-list values. This PR fixes the pickling behavior of traited specs containing these types of traits. Additionally, this PR also avoids the ``modify_paths`` function that was causing problems originally in nipy#2944. Therefore, this PR effectively make results files static, meaning: caching if the ``base_dir`` of the workflow is changed will not work anymore. I plan to re-insert this feature (results file mobility) with nipy#2971. This PR is just to split that one in more digestible bits. All the boilerplate mentioned above has been cleaned up.
|
Love to see it |
|
And most of the green are doctests 🥇 |
|
|
effigies
reviewed
Aug 1, 2019
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
effigies
reviewed
Aug 1, 2019
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
|
All green (c8a3797) |
Codecov Report
@@ Coverage Diff @@
## master #2983 +/- ##
==========================================
- Coverage 67.65% 64.26% -3.39%
==========================================
Files 344 342 -2
Lines 43835 43747 -88
Branches 5486 5475 -11
==========================================
- Hits 29657 28115 -1542
- Misses 13466 14537 +1071
- Partials 712 1095 +383
Continue to review full report at Codecov.
|
4 similar comments
Codecov Report
@@ Coverage Diff @@
## master #2983 +/- ##
==========================================
- Coverage 67.65% 64.26% -3.39%
==========================================
Files 344 342 -2
Lines 43835 43747 -88
Branches 5486 5475 -11
==========================================
- Hits 29657 28115 -1542
- Misses 13466 14537 +1071
- Partials 712 1095 +383
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2983 +/- ##
==========================================
- Coverage 67.65% 64.26% -3.39%
==========================================
Files 344 342 -2
Lines 43835 43747 -88
Branches 5486 5475 -11
==========================================
- Hits 29657 28115 -1542
- Misses 13466 14537 +1071
- Partials 712 1095 +383
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2983 +/- ##
==========================================
- Coverage 67.65% 64.26% -3.39%
==========================================
Files 344 342 -2
Lines 43835 43747 -88
Branches 5486 5475 -11
==========================================
- Hits 29657 28115 -1542
- Misses 13466 14537 +1071
- Partials 712 1095 +383
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2983 +/- ##
==========================================
- Coverage 67.65% 64.26% -3.39%
==========================================
Files 344 342 -2
Lines 43835 43747 -88
Branches 5486 5475 -11
==========================================
- Hits 29657 28115 -1542
- Misses 13466 14537 +1071
- Partials 712 1095 +383
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #2944 has uncovered a rats-nest hidden in the engine. In
resolving that issue, I found out that a great deal of boilerplate was
set in place when loading/saving results to deal with
OutputMulti{Object,Path}traits. The reason being that these traitsflatten single-element-list values.
This PR fixes the pickling behavior of traited specs containing these
types of traits.
Additionally, this PR also avoids the
modify_pathsfunction that wascausing problems originally in #2944. Therefore, this PR effectively
make results files static, meaning: caching if the
base_dirof theworkflow is changed will not work anymore.
I plan to re-insert this feature (results file mobility) with #2971.
This PR is just to split that one in more digestible bits.
All the boilerplate mentioned above has been cleaned up.
Fixes #2968
Acknowledgment