Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add "GenericLabel" to antsRegistration interpolation option. #3424

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

axiezai
Copy link
Contributor

@axiezai axiezai commented Dec 15, 2021

Summary

Fixes #3423, i did make check-before-commit but I need some help editing the docs so that the new option is reflected in the HTML.

List of changes proposed in this PR (pull-request)

  • Add GenericLabel to antsRegistration interface's interpolation option

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #3424 (01e4a5e) into master (5ac2f18) will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3424      +/-   ##
==========================================
- Coverage   65.21%   64.35%   -0.87%     
==========================================
  Files         307      307              
  Lines       40478    40478              
  Branches     5352     5352              
==========================================
- Hits        26399    26049     -350     
- Misses      13008    13371     +363     
+ Partials     1071     1058      -13     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/ants/registration.py 73.09% <ø> (ø)
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 48.38% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 50.92% <0.00%> (-14.36%) ⬇️
nipype/interfaces/ants/base.py 65.30% <0.00%> (-8.17%) ⬇️
nipype/interfaces/spm/base.py 60.06% <0.00%> (-7.60%) ⬇️
nipype/interfaces/io.py 48.09% <0.00%> (-7.15%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac2f18...01e4a5e. Read the comment docs.

@effigies
Copy link
Member

The docs should auto-update.

@axiezai
Copy link
Contributor Author

axiezai commented Dec 15, 2021

Hmm do you have any idea why nipype/interfaces/tests/test_auto_Dcm2nii.py got deleted by make check-before-commit locally?

@axiezai
Copy link
Contributor Author

axiezai commented Dec 15, 2021

reverted that commit so the tests are all there now.

@effigies effigies changed the title [WIP] Add GenericLabel to antsRegistration interpolation option. ENH: Add "GenericLabel" to antsRegistration interpolation option. Dec 15, 2021
@effigies
Copy link
Member

Thanks! Not sure why make check-before-commit did something weird...

@effigies effigies merged commit cd4c34d into nipy:master Dec 15, 2021
@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Add GenericLabel to antsRegistration interface as MultiLabel is outdated.
2 participants