WIP: Major refactor to move from enthought traits to traitlets #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this effort been abandoned or replaced by other efforts? |
|
slowed down by lack of resources - good topic for us to hack on in hawaii! |
| def execfile(fname, glob, loc=None): | ||
| loc = loc if (loc is not None) else glob | ||
| with open(fname, 'rb') as f: | ||
| exec(compile(f.read(), fname, 'exec'), glob, loc) |
|
Given that traits is now available for python 3, this is being abandoned for the moment. |
|
Does this mean that it just works (TM) on python 3? |
|
@inati - yes - we are now py2 and py3 compatible (still working out some kinks here and there with unicode, but all tests pass on both) |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to move away from traits and provide a path to py3k compatibility. The other intent is to reduce the pickling hacks in place when creating trait objects on the fly in mapnode and other interfaces.
Since this forms the basis for all of nipype interfaces, we will make sure that code coverage is maintained or extended as part of this refactor.