-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nipype_cmd - run any Interface from a command line #795
Conversation
@Garyfallidis @MrBago @oesteban This is just a proof of concept, but it should give you a general idea. |
This is great :). Thanks! |
Cool, a dipy example is needed. Let us know how we can help. |
Cool! Pick a simple (few inputs and outputs) DWI processing step that one On Tue, Feb 18, 2014 at 4:57 PM, Eleftherios Garyfallidis <
|
Hi guys, sorry for not having responded to this PR. This happened because we had to prioritize other algorithmic PRs. We need more people reviewing the Dipy PRs. There are too many and quite large often. I hope that we will start looking to this again soon. |
@Garyfallidis I'm gonna clean this up today. Any comments/requests? |
bca8103
to
e6e6c72
Compare
@Garyfallidis here's a dipy example:
|
Hi @chrisfilo. How can I help? If I remember correctly the idea was to have a common interface in Dipy and Nipype so we can write scripts in Dipy and have them available in Nipype without having the dependency of Nipype in Dipy. Am I correct? |
nipype_cmd is written in a very generic way right now - it can turn any Nipype Interface into a command line script. Interfaces it operates on do not have to eve nbe part of nipype package. You could do:
but also:
if dipy was installed and provided Nipype Interfaces. Does this functionality help you in your use cases? |
Ready for review. Tests fail only on python 2.6. They will start passing after #1069 will be merged ;) |
351ea1f
to
69453de
Compare
http://github.com/nipy/nipype/issues/issue/788 Moved and cleaned up the run_interface tool.
This reverts commit a9163f0.
This reverts commit 25fef6a.
69453de
to
49f2bd9
Compare
@@ -37,6 +37,7 @@ | |||
saving_workflows | |||
spmmcr | |||
mipav | |||
nipypecmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
On Wed, Mar 18, 2015 at 3:49 PM, Satrajit Ghosh notifications@github.com
wrote:
In doc/users/index.rst
#795 (comment):@@ -37,6 +37,7 @@
saving_workflows
spmmcr
mipav
- nipypecmd
this file is missing.
—
Reply to this email directly or view it on GitHub
https://github.com/nipy/nipype/pull/795/files#r26715700.
if hasattr(v, "mandatory") and v.mandatory: | ||
parser.add_argument(k, help=v.desc) | ||
else: | ||
parser.add_argument("--%s"%k, dest=k, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to add type information here from traits? then that will help reduce the code in run_instance
also see here: https://github.com/nipy/nipype/blob/master/examples/fmri_ants_openfmri.py#L1042 how to add default values and types |
it would also be sweet to add nipype memcache options to this! perhaps that's a sprint item. |
nipype_cmd - run any Interface from a command line
nipype_cmd --help
nipype_cmd nipype.interfaces.nipy
nipype_cmd nipype.interfaces.nipy ComputeMask --help
nipype_cmd nipype.interfaces.nipy ComputeMask /tmp/mean_volume.nii