Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FNIRT output specification issues #23

Closed
djarecka opened this issue Nov 4, 2021 · 3 comments
Closed

FNIRT output specification issues #23

djarecka opened this issue Nov 4, 2021 · 3 comments

Comments

@djarecka
Copy link
Contributor

djarecka commented Nov 4, 2021

@htwangtw - I was debugging failing tests and it looks like there are several field in the FNIRT output spec (e.g. field_file) that have in_file as the only requirements, but this is not right.
In nipype one can specify full name by providing a string or set it to True in order to use the default nipype template. @effigies suggested that we don't have to support both, we could just allow for some user defined template.

Let me know if you have thoughts about it. Don't remember if we discussed similar cases

@htwangtw
Copy link
Collaborator

I agree with @effigies that we should just pick one.
I am inclined to ask for user defined template, as that would be more consistent with the docstring of FSL FNIRT. Tried to play around with it today but no success with fixing it.

@effigies
Copy link
Contributor

effigies commented Dec 16, 2022

@ghisvail Is this resolved?

@ghisvail
Copy link
Contributor

There is no output spec for FNIRT anymore as a result of #41.

Everything is now derived from in_file as template for the default name in the input spec. This was necessary to get the tests green again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants