Skip to content

Add renames option to Python target #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 16, 2017
Merged

Add renames option to Python target #121

merged 10 commits into from
Mar 16, 2017

Conversation

@dahlia
Copy link
Member

@dahlia dahlia commented Mar 16, 2017 •
edited
Loading

This patch introduces a new option targets.python.renames. It is a translation table of ModulePath to ModulePath and purposes to rename the matched module paths. Here's an example (which motivated me to implement this):

[targets.python.renames]
contract = "contract-schema"

It makes the root module contract to be compiled to Python package contract_schema. See docs/target/python.md for more details.

@dahlia dahlia added the typ:enhance Type: Enhancement/new feature label Mar 16, 2017
@dahlia dahlia self-assigned this Mar 16, 2017
kanghyojun
kanghyojun reviewed Mar 16, 2017
View reviewed changes
docs/target/python.md
@@ -0,0 +1,91 @@
Python target
Copy link
Member

@kanghyojun kanghyojun Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍훌륭합니다

@dahlia dahlia merged commit f162978 into nirum-lang:master Mar 16, 2017
@dahlia dahlia added cat:packaging Category: Nirum schema packaging (not compiler packaging) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python labels Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanghyojun kanghyojun kanghyojun approved these changes

@yjroot yjroot Awaiting requested review from yjroot

@Kroisse Kroisse Awaiting requested review from Kroisse

@AiOO AiOO Awaiting requested review from AiOO

@heejongahn heejongahn Awaiting requested review from heejongahn

Assignees

@dahlia dahlia

Labels

cat:packaging Category: Nirum schema packaging (not compiler packaging) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python typ:enhance Type: Enhancement/new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dahlia @kanghyojun