Fix NameError from forward references of generated Python codes - #146
Merged
Conversation
dahlia
force-pushed
the
forward-references
branch
2 times, most recently
from
June 22, 2017 20:27
14fee95 to
2eeda64
Compare
dahlia
force-pushed
the
forward-references
branch
from
June 22, 2017 21:20
2eeda64 to
e9bbff0
Compare
kanghyojun
approved these changes
Jun 23, 2017
dahlia
added
cmp:compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the Python target so that generated Python codes doesn't directly refer forward references but indirectly refer them behind its wrapped lambda. It also requires runtime library's changes; nirum-lang/nirum-python#88 need to be merged first.