Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameError from forward references of generated Python codes #146

Merged
merged 2 commits into from Jun 23, 2017

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented Jun 22, 2017

This patch fixes the Python target so that generated Python codes doesn't directly refer forward references but indirectly refer them behind its wrapped lambda. It also requires runtime library's changes; nirum-lang/nirum-python#88 need to be merged first.

@dahlia dahlia added the typ:bug Type: Bug/defect label Jun 22, 2017
@dahlia dahlia self-assigned this Jun 22, 2017
@dahlia dahlia requested a review from kanghyojun June 22, 2017 15:43
@dahlia dahlia force-pushed the forward-references branch 2 times, most recently from 14fee95 to 2eeda64 Compare June 22, 2017 20:27
@dahlia dahlia merged commit 8ddabca into nirum-lang:master Jun 23, 2017
@dahlia dahlia added cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python labels Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) target:python typ:bug Type: Bug/defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants